diff options
| author | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-09-23 21:48:03 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-10-02 16:47:09 +0300 |
| commit | 44577f1d98545fff565df81793418e40eecc7394 (patch) | |
| tree | 5d991116b14e10f154a475e47f1afbd505fd5ded /drivers/base/arch_topology.c | |
| parent | 6284a6e8940341beb71ea7970388418eb3dd473d (diff) | |
| download | linux-44577f1d98545fff565df81793418e40eecc7394.tar.xz | |
platform/x86: intel_pmc_core: do not create a static struct device
A struct device is a dynamic structure, with reference counting.
"Tricking" the kernel to make a dynamic structure static, by working
around the driver core release detection logic, is not nice.
Because of this, this code has been used as an example for others on
"how to do things", which is just about the worst thing possible to have
happen.
Fix this all up by making the platform device dynamic and providing a
real release function.
Fixes: b02f6a2ef0a1 ("platform/x86: intel_pmc_core: Attach using APCI HID "INT33A1"")
Cc: Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com>
Cc: Vishwanath Somayaji <vishwanath.somayaji@intel.com>
Cc: Darren Hart <dvhart@infradead.org>
Cc: Andy Shevchenko <andy@infradead.org>
Reported-by: Maximilian Luz <luzmaximilian@gmail.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Rajat Jain <rajatja@google.com>
Link: https://lore.kernel.org/r/20200923184803.192265-1-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/base/arch_topology.c')
0 files changed, 0 insertions, 0 deletions