diff options
| author | Tao Ren <taoren@fb.com> | 2018-10-04 00:53:50 +0300 |
|---|---|---|
| committer | Daniel Lezcano <daniel.lezcano@linaro.org> | 2018-12-19 00:22:23 +0300 |
| commit | 86fe57fc47b17b3528fa5497fc57e158d846c4ea (patch) | |
| tree | 0cb9600b95fa0300f5834bd280d9bcbd6e677604 /drivers/clocksource/timer-imx-tpm.c | |
| parent | 5eb73c831171115d3b4347e1e7124a5a35d8086c (diff) | |
| download | linux-86fe57fc47b17b3528fa5497fc57e158d846c4ea.tar.xz | |
clocksource/drivers/fttmr010: Fix invalid interrupt register access
TIMER_INTR_MASK register (Base Address of Timer + 0x38) is not designed
for masking interrupts on ast2500 chips, and it's not even listed in
ast2400 datasheet, so it's not safe to access TIMER_INTR_MASK on aspeed
chips.
Similarly, TIMER_INTR_STATE register (Base Address of Timer + 0x34) is
not interrupt status register on ast2400 and ast2500 chips. Although
there is no side effect to reset the register in fttmr010_common_init(),
it's just misleading to do so.
Besides, "count_down" is renamed to "is_aspeed" in "fttmr010" structure,
and more comments are added so the code is more readble.
Signed-off-by: Tao Ren <taoren@fb.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Diffstat (limited to 'drivers/clocksource/timer-imx-tpm.c')
0 files changed, 0 insertions, 0 deletions