diff options
| author | Gustavo A. R. Silva <gustavo@embeddedor.com> | 2020-02-12 02:10:45 +0300 |
|---|---|---|
| committer | Sudeep Holla <sudeep.holla@arm.com> | 2020-02-20 20:11:28 +0300 |
| commit | 4ddfb4af07c82e7f63c28347e463046aa14c1837 (patch) | |
| tree | 3e9eec88d5d7f7a6a2aa1b402b57144fbf8c1931 /drivers/firmware/arm_scmi/shmem.c | |
| parent | 5c8a47a5a91d4d6e185f758d61997613d9c5d6ac (diff) | |
| download | linux-4ddfb4af07c82e7f63c28347e463046aa14c1837.tar.xz | |
firmware: arm_scmi: Replace zero-length array with flexible-array member
The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:
struct foo {
int stuff;
struct boo array[];
};
By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertenly introduced[3] to the codebase from now on.
This issue was found with the help of Coccinelle.
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")
Replace the zero-length member "msg_payload" in scmi_shared_mem
structure with flexible-array.
Link: https://lore.kernel.org/r/20200211231045.GA13956@embeddedor
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
[ rebased the change as files are moved around ]
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Diffstat (limited to 'drivers/firmware/arm_scmi/shmem.c')
| -rw-r--r-- | drivers/firmware/arm_scmi/shmem.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/firmware/arm_scmi/shmem.c b/drivers/firmware/arm_scmi/shmem.c index ca0ffd302ea2..e1e816e0018c 100644 --- a/drivers/firmware/arm_scmi/shmem.c +++ b/drivers/firmware/arm_scmi/shmem.c @@ -26,7 +26,7 @@ struct scmi_shared_mem { #define SCMI_SHMEM_FLAG_INTR_ENABLED BIT(0) __le32 length; __le32 msg_header; - u8 msg_payload[0]; + u8 msg_payload[]; }; void shmem_tx_prepare(struct scmi_shared_mem __iomem *shmem, |