diff options
author | Bjorn Helgaas <bhelgaas@google.com> | 2023-03-07 21:19:14 +0300 |
---|---|---|
committer | Jakub Kicinski <kuba@kernel.org> | 2023-03-09 10:34:38 +0300 |
commit | 5f00358b5e905a1db1077006d01cd5d207f91fb0 (patch) | |
tree | 21d761abfb0629a292cb114b9f6de11614b24f48 /drivers/net/ethernet/broadcom/bnx2x/bnx2x.h | |
parent | b4e24578b4841b6abac38fd40fddba6caa9a656a (diff) | |
download | linux-5f00358b5e905a1db1077006d01cd5d207f91fb0.tar.xz |
bnx2: Drop redundant pci_enable_pcie_error_reporting()
pci_enable_pcie_error_reporting() enables the device to send ERR_*
Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is
native"), the PCI core does this for all devices during enumeration, so the
driver doesn't need to do it itself.
Remove the redundant pci_enable_pcie_error_reporting() call from the
driver. Also remove the corresponding pci_disable_pcie_error_reporting()
from the driver .remove() path.
Note that this only controls ERR_* Messages from the device. An ERR_*
Message may cause the Root Port to generate an interrupt, depending on the
AER Root Error Command register managed by the AER service driver.
cd709aa90648 ("bnx2: Add PCI Advanced Error Reporting support.") added
pci_enable_pcie_error_reporting() for all devices, and c239f279e571 ("bnx2:
Enable AER on PCIE devices only") restricted it to BNX2_CHIP_5709 devices
to avoid an error message when it failed on non-PCIe devices. The PCI core
only enables PCIe error reporting on PCIe devices, which I assume means
BNX2_CHIP_5709.
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Rasesh Mody <rmody@marvell.com>
Cc: GR-Linux-NIC-Dev@marvell.com
Reviewed-by: Michael Chan <michael.chan@broadcom.com>
Acked-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/ethernet/broadcom/bnx2x/bnx2x.h')
0 files changed, 0 insertions, 0 deletions