diff options
| author | Hao Chen <chenhao418@huawei.com> | 2023-10-19 12:13:52 +0300 |
|---|---|---|
| committer | Will Deacon <will@kernel.org> | 2023-10-19 17:30:49 +0300 |
| commit | 50b560783f7f71790bcf70e9e9855155fb0af8c1 (patch) | |
| tree | 94224f7f4f4d8e91db5f389a41a378cf3c713147 /drivers/perf/fsl_imx9_ddr_perf.c | |
| parent | 1f33cdef8ca174661fb0d82d0f74fd0589dc9e46 (diff) | |
| download | linux-50b560783f7f71790bcf70e9e9855155fb0af8c1.tar.xz | |
drivers/perf: hisi: use cpuhp_state_remove_instance_nocalls() for hisi_hns3_pmu uninit process
When tearing down a 'hisi_hns3' PMU, we mistakenly run the CPU hotplug
callbacks after the device has been unregistered, leading to fireworks
when we try to execute empty function callbacks within the driver:
| Unable to handle kernel NULL pointer dereference at virtual address 0000000000000000
| CPU: 0 PID: 15 Comm: cpuhp/0 Tainted: G W O 5.12.0-rc4+ #1
| Hardware name: , BIOS KpxxxFPGA 1P B600 V143 04/22/2021
| pstate: 80400009 (Nzcv daif +PAN -UAO -TCO BTYPE=--)
| pc : perf_pmu_migrate_context+0x98/0x38c
| lr : perf_pmu_migrate_context+0x94/0x38c
|
| Call trace:
| perf_pmu_migrate_context+0x98/0x38c
| hisi_hns3_pmu_offline_cpu+0x104/0x12c [hisi_hns3_pmu]
Use cpuhp_state_remove_instance_nocalls() instead of
cpuhp_state_remove_instance() so that the notifiers don't execute after
the PMU device has been unregistered.
Fixes: 66637ab137b4 ("drivers/perf: hisi: add driver for HNS3 PMU")
Signed-off-by: Hao Chen <chenhao418@huawei.com>
Signed-off-by: Jijie Shao <shaojijie@huawei.com>
Reviewed-by: Yicong Yang <yangyicong@hisilicon.com>
Link: https://lore.kernel.org/r/20231019091352.998964-1-shaojijie@huawei.com
[will: Rewrote commit message]
Signed-off-by: Will Deacon <will@kernel.org>
Diffstat (limited to 'drivers/perf/fsl_imx9_ddr_perf.c')
0 files changed, 0 insertions, 0 deletions