summaryrefslogtreecommitdiff
path: root/drivers/pwm/pwm-lpss-platform.c
diff options
context:
space:
mode:
authorHans de Goede <hdegoede@redhat.com>2020-09-03 14:23:27 +0300
committerHans de Goede <hdegoede@redhat.com>2020-09-06 16:38:01 +0300
commit547d9e9261d294f0a2597d9e9c55ba48f80716ab (patch)
treeceb7f144da1e93e5172336a1e9ba5493bef654a3 /drivers/pwm/pwm-lpss-platform.c
parentd6d54bacb1dd02a31ed9d8e3db028639da292615 (diff)
downloadlinux-547d9e9261d294f0a2597d9e9c55ba48f80716ab.tar.xz
pwm: lpss: Remove suspend/resume handlers
PWM controller drivers should not restore the PWM state on resume. The convention is that PWM consumers do this by calling pwm_apply_state(), so that it can be done at the exact moment when the consumer needs the state to be stored, avoiding e.g. backlight flickering. The only in kernel consumers of the pwm-lpss code, the i915 driver and the pwm-class sysfs interface code both correctly restore the state on resume, so there is no need to do this in the pwm-lpss code. More-over the removed resume handler is buggy, since it blindly restores the ctrl-register contents without setting the update bit, which is necessary to get the controller to actually use/apply the restored base-unit and on-time-div values. Acked-by: Thierry Reding <thierry.reding@gmail.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20200903112337.4113-8-hdegoede@redhat.com
Diffstat (limited to 'drivers/pwm/pwm-lpss-platform.c')
-rw-r--r--drivers/pwm/pwm-lpss-platform.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/pwm/pwm-lpss-platform.c b/drivers/pwm/pwm-lpss-platform.c
index 48f34d20aecd..c6502cf7a7af 100644
--- a/drivers/pwm/pwm-lpss-platform.c
+++ b/drivers/pwm/pwm-lpss-platform.c
@@ -89,7 +89,6 @@ static int pwm_lpss_prepare(struct device *dev)
static const struct dev_pm_ops pwm_lpss_platform_pm_ops = {
.prepare = pwm_lpss_prepare,
- SET_SYSTEM_SLEEP_PM_OPS(pwm_lpss_suspend, pwm_lpss_resume)
};
static const struct acpi_device_id pwm_lpss_acpi_match[] = {