summaryrefslogtreecommitdiff
path: root/drivers/scsi/lpfc/lpfc_vport.c
diff options
context:
space:
mode:
authorBodo Stroesser <bostroesser@gmail.com>2022-05-17 22:29:13 +0300
committerMartin K. Petersen <martin.petersen@oracle.com>2022-05-20 03:16:27 +0300
commit325d5c5fb216674296f3902a8902b942da3adc5b (patch)
tree98cee22612befcbff95316d83366e73fc4e6ecd2 /drivers/scsi/lpfc/lpfc_vport.c
parentd627660c22b51121262c03dfa1a51bf54361f5a9 (diff)
downloadlinux-325d5c5fb216674296f3902a8902b942da3adc5b.tar.xz
scsi: target: tcmu: Avoid holding XArray lock when calling lock_page
In tcmu_blocks_release(), lock_page() is called to prevent a race causing possible data corruption. Since lock_page() might sleep, calling it while holding XArray lock is a bug. To fix this, replace the xas_for_each() call with xa_for_each_range(). Since the latter does its own handling of XArray locking, the xas_lock() and xas_unlock() calls around the original loop are no longer necessary. The switch to xa_for_each_range() slows down the loop slightly. This is acceptable since tcmu_blocks_release() is not relevant for performance. Link: https://lore.kernel.org/r/20220517192913.21405-1-bostroesser@gmail.com Fixes: bb9b9eb0ae2e ("scsi: target: tcmu: Fix possible data corruption") Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Bodo Stroesser <bostroesser@gmail.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/lpfc/lpfc_vport.c')
0 files changed, 0 insertions, 0 deletions