diff options
| author | Chen Jiahao <chenjiahao16@huawei.com> | 2023-07-28 10:57:29 +0300 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2023-07-28 17:06:14 +0300 |
| commit | 71ee2a4f95e205bd33e79c7bd4bece3885e0e366 (patch) | |
| tree | 469928bc57c5b0be8efb61f776ae1cf9d222bafb /drivers/spi/spi-microchip-core.c | |
| parent | 026badeb7055e41000e4b139833ca5bafe360eb6 (diff) | |
| download | linux-71ee2a4f95e205bd33e79c7bd4bece3885e0e366.tar.xz | |
spi: microchip-core: Clean up redundant dev_err_probe()
Refering to platform_get_irq()'s definition, the return value has
already been checked if ret < 0, and printed via dev_err_probe().
Calling dev_err_probe() one more time outside platform_get_irq()
is obviously redundant.
Furthermore, platform_get_irq() will never return irq equals 0,
removing spi->irq == 0 checking to clean it up.
Signed-off-by: Chen Jiahao <chenjiahao16@huawei.com>
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Link: https://lore.kernel.org/r/20230728075729.3451867-1-chenjiahao16@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi/spi-microchip-core.c')
| -rw-r--r-- | drivers/spi/spi-microchip-core.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/spi/spi-microchip-core.c b/drivers/spi/spi-microchip-core.c index b59e8a0c5b97..b451cd4860ec 100644 --- a/drivers/spi/spi-microchip-core.c +++ b/drivers/spi/spi-microchip-core.c @@ -530,10 +530,8 @@ static int mchp_corespi_probe(struct platform_device *pdev) return PTR_ERR(spi->regs); spi->irq = platform_get_irq(pdev, 0); - if (spi->irq <= 0) - return dev_err_probe(&pdev->dev, -ENXIO, - "invalid IRQ %d for SPI controller\n", - spi->irq); + if (spi->irq < 0) + return spi->irq; ret = devm_request_irq(&pdev->dev, spi->irq, mchp_corespi_interrupt, IRQF_SHARED, dev_name(&pdev->dev), master); |