summaryrefslogtreecommitdiff
path: root/drivers/staging/media/rkvdec/rkvdec.c
diff options
context:
space:
mode:
authorEzequiel Garcia <ezequiel@collabora.com>2020-06-24 22:28:00 +0300
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>2020-07-19 09:13:24 +0300
commitb3ab1c6058fad8cd5726f24e9ed9053e43bb2af4 (patch)
treefb02c7980fd3ddfd76ee15c39d8652ce8046619c /drivers/staging/media/rkvdec/rkvdec.c
parentd6129d36b305e9943bc6af0e4f0f7f6a77ded9b0 (diff)
downloadlinux-b3ab1c6058fad8cd5726f24e9ed9053e43bb2af4.tar.xz
media: Add V4L2_TYPE_IS_CAPTURE helper
It's all too easy to get confused by the V4L2_TYPE_IS_OUTPUT macro, when it's used as !V4L2_TYPE_IS_OUTPUT. Reduce the risk of confusion with macro to explicitly check for the CAPTURE queue type case. This change does not affect functionality, and it's only intended to make the code more readable. Suggested-by: Nicolas Dufresne <nicolas.dufresne@collabora.com> Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> [hverkuil-cisco@xs4all.nl: checkpatch: align with parenthesis] Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Diffstat (limited to 'drivers/staging/media/rkvdec/rkvdec.c')
-rw-r--r--drivers/staging/media/rkvdec/rkvdec.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/media/rkvdec/rkvdec.c b/drivers/staging/media/rkvdec/rkvdec.c
index 225eeca73356..fd68671f0286 100644
--- a/drivers/staging/media/rkvdec/rkvdec.c
+++ b/drivers/staging/media/rkvdec/rkvdec.c
@@ -489,7 +489,7 @@ static int rkvdec_start_streaming(struct vb2_queue *q, unsigned int count)
const struct rkvdec_coded_fmt_desc *desc;
int ret;
- if (!V4L2_TYPE_IS_OUTPUT(q->type))
+ if (V4L2_TYPE_IS_CAPTURE(q->type))
return 0;
desc = ctx->coded_fmt_desc;