diff options
| author | Alexei Potashnik <alexei@purestorage.com> | 2015-07-22 01:07:56 +0300 |
|---|---|---|
| committer | Nicholas Bellinger <nab@linux-iscsi.org> | 2015-07-31 09:10:54 +0300 |
| commit | 9547308bda296b6f69876c840a0291fcfbeddbb8 (patch) | |
| tree | 2bf7ea2c0dacfe8ca12c10a74d7ce5597d39e610 /drivers/target/target_core_spc.c | |
| parent | 9450918293b3c35f11883231a53da1aed2c78403 (diff) | |
| download | linux-9547308bda296b6f69876c840a0291fcfbeddbb8.tar.xz | |
target/iscsi: Fix double free of a TUR followed by a solicited NOPOUT
Make sure all non-READ SCSI commands get targ_xfer_tag initialized
to 0xffffffff, not just WRITEs.
Double-free of a TUR cmd object occurs under the following scenario:
1. TUR received (targ_xfer_tag is uninitialized and left at 0)
2. TUR status sent
3. First unsolicited NOPIN is sent to initiator (gets targ_xfer_tag of 0)
4. NOPOUT for NOPIN (with TTT=0) arrives
- its ExpStatSN acks TUR status, TUR is queued for removal
- LIO tries to find NOPIN with TTT=0, but finds the same TUR instead,
TUR is queued for removal for the 2nd time
(Drop unbalanced conditional bracket usage - nab)
Signed-off-by: Alexei Potashnik <alexei@purestorage.com>
Signed-off-by: Spencer Baugh <sbaugh@catern.com>
Cc: <stable@vger.kernel.org> # v3.1+
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Diffstat (limited to 'drivers/target/target_core_spc.c')
0 files changed, 0 insertions, 0 deletions