diff options
| author | David Sterba <dsterba@suse.com> | 2024-01-24 17:59:36 +0300 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2024-03-04 18:24:48 +0300 |
| commit | 5378ea6ea095e25bb32fa1a76e29c8aa4a3ff6c5 (patch) | |
| tree | 8fd021bc34e4367f5a5ff1d7249b7c20cc1498d6 /fs/btrfs/uuid-tree.c | |
| parent | 53e4d8c29095f169be2b1593bff8e4feb44ce94e (diff) | |
| download | linux-5378ea6ea095e25bb32fa1a76e29c8aa4a3ff6c5.tar.xz | |
btrfs: unify handling of return values of btrfs_insert_empty_items()
The error values returned by btrfs_insert_empty_items() are following
the common patter of 0/-errno, but some callers check for a value > 0,
which can't happen. Document that and update calls to not expect
positive values.
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: Anand Jain <anand.jain@oracle.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs/uuid-tree.c')
| -rw-r--r-- | fs/btrfs/uuid-tree.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/btrfs/uuid-tree.c b/fs/btrfs/uuid-tree.c index b8c6e46dd499..b0aff297d67d 100644 --- a/fs/btrfs/uuid-tree.c +++ b/fs/btrfs/uuid-tree.c @@ -113,7 +113,7 @@ int btrfs_uuid_tree_add(struct btrfs_trans_handle *trans, u8 *uuid, u8 type, ret = btrfs_insert_empty_item(trans, uuid_root, path, &key, sizeof(subid_le)); - if (ret >= 0) { + if (ret == 0) { /* Add an item for the type for the first time */ eb = path->nodes[0]; slot = path->slots[0]; |