diff options
author | Gustavo A. R. Silva <gustavoars@kernel.org> | 2021-03-26 04:11:17 +0300 |
---|---|---|
committer | Steve French <stfrench@microsoft.com> | 2021-04-26 00:28:22 +0300 |
commit | 9f4c6eed26a2b7e3ce20c54e691357e0e69cc8c2 (patch) | |
tree | 42950e3086a775fa76e8a88defc54fcf454ab1f6 /fs/cifs/cifssmb.c | |
parent | 5e14c7240ae9ada2b0747a57f0deb5643102f64c (diff) | |
download | linux-9f4c6eed26a2b7e3ce20c54e691357e0e69cc8c2.tar.xz |
cifs: cifspdu.h: Replace one-element array with flexible-array member
There is a regular need in the kernel to provide a way to declare having
a dynamically sized set of trailing elements in a structure. Kernel code
should always use “flexible array members”[1] for these cases. The older
style of one-element or zero-length arrays should no longer be used[2].
Also, this helps with the ongoing efforts to enable -Warray-bounds by
fixing the following warning:
CC [M] fs/cifs/cifssmb.o
fs/cifs/cifssmb.c: In function ‘CIFSFindNext’:
fs/cifs/cifssmb.c:4636:23: warning: array subscript 1 is above array bounds of ‘char[1]’ [-Warray-bounds]
4636 | pSMB->ResumeFileName[name_len+1] = 0;
| ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~
[1] https://en.wikipedia.org/wiki/Flexible_array_member
[2] https://www.kernel.org/doc/html/v5.10/process/deprecated.html#zero-length-and-one-element-arrays
Link: https://github.com/KSPP/linux/issues/79
Link: https://github.com/KSPP/linux/issues/109
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Aurelien Aptel <aaptel@suse.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Diffstat (limited to 'fs/cifs/cifssmb.c')
0 files changed, 0 insertions, 0 deletions