diff options
author | Eric Biggers <ebiggers@google.com> | 2021-01-12 22:02:47 +0300 |
---|---|---|
committer | Jan Kara <jack@suse.cz> | 2021-01-13 19:26:33 +0300 |
commit | e2728c5621fd9c68c65a6647875a1d1c67b9f257 (patch) | |
tree | 22924de355cb209301133ffa057e6c8302b5b266 /fs/gfs2/super.c | |
parent | ff4136e64d129c4b617331d6c84a3e1781dda70d (diff) | |
download | linux-e2728c5621fd9c68c65a6647875a1d1c67b9f257.tar.xz |
fs: don't call ->dirty_inode for lazytime timestamp updates
There is no need to call ->dirty_inode for lazytime timestamp updates
(i.e. for __mark_inode_dirty(I_DIRTY_TIME)), since by the definition of
lazytime, filesystems must ignore these updates. Filesystems only need
to care about the updated timestamps when they expire.
Therefore, only call ->dirty_inode when I_DIRTY_INODE is set.
Based on a patch from Christoph Hellwig:
https://lore.kernel.org/r/20200325122825.1086872-4-hch@lst.de
Link: https://lore.kernel.org/r/20210112190253.64307-6-ebiggers@kernel.org
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Diffstat (limited to 'fs/gfs2/super.c')
-rw-r--r-- | fs/gfs2/super.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/fs/gfs2/super.c b/fs/gfs2/super.c index 2f56acc41c04..042b94288ff1 100644 --- a/fs/gfs2/super.c +++ b/fs/gfs2/super.c @@ -562,8 +562,6 @@ static void gfs2_dirty_inode(struct inode *inode, int flags) int need_endtrans = 0; int ret; - if (!(flags & I_DIRTY_INODE)) - return; if (unlikely(gfs2_withdrawn(sdp))) return; if (!gfs2_glock_is_locked_by_me(ip->i_gl)) { |