diff options
| author | Patrick Ho <Patrick.Ho@netapp.com> | 2021-08-21 09:56:26 +0300 |
|---|---|---|
| committer | Chuck Lever <chuck.lever@oracle.com> | 2021-09-30 17:58:52 +0300 |
| commit | 1d625050c7c2dd877e108e382b8aaf1ae3cfe1f4 (patch) | |
| tree | fb7ee0160c5035a2ea424b9e27bb1529f9191311 /fs/nfsd/nfs4xdr.c | |
| parent | 02579b2ff8b0becfb51d85a975908ac4ab15fba8 (diff) | |
| download | linux-1d625050c7c2dd877e108e382b8aaf1ae3cfe1f4.tar.xz | |
nfsd: fix error handling of register_pernet_subsys() in init_nfsd()
init_nfsd() should not unregister pernet subsys if the register fails
but should instead unwind from the last successful operation which is
register_filesystem().
Unregistering a failed register_pernet_subsys() call can result in
a kernel GPF as revealed by programmatically injecting an error in
register_pernet_subsys().
Verified the fix handled failure gracefully with no lingering nfsd
entry in /proc/filesystems. This change was introduced by the commit
bd5ae9288d64 ("nfsd: register pernet ops last, unregister first"),
the original error handling logic was correct.
Fixes: bd5ae9288d64 ("nfsd: register pernet ops last, unregister first")
Cc: stable@vger.kernel.org
Signed-off-by: Patrick Ho <Patrick.Ho@netapp.com>
Acked-by: J. Bruce Fields <bfields@redhat.com>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Diffstat (limited to 'fs/nfsd/nfs4xdr.c')
0 files changed, 0 insertions, 0 deletions