summaryrefslogtreecommitdiff
path: root/fs/quota
diff options
context:
space:
mode:
authorYangtao Li <frank.li@vivo.com>2023-02-27 15:02:16 +0300
committerJan Kara <jack@suse.cz>2023-03-20 19:27:42 +0300
commitc87d175d0ae715a1cdd9a315253f3fb410fb0421 (patch)
treefbc470f9bfbf47b8cd932621212cefbde3ccf0a1 /fs/quota
parentf8107c996f5419a5b964b9796d736c7b81f099a0 (diff)
downloadlinux-c87d175d0ae715a1cdd9a315253f3fb410fb0421.tar.xz
quota: make dquot_set_dqinfo return errors from ->write_info
dquot_set_dqinfo() ignores the return code from the ->write_info call, which means that quotacalls like Q_SETINFO never see the error. This doesn't seem right, so fix that. Signed-off-by: Yangtao Li <frank.li@vivo.com> Signed-off-by: Jan Kara <jack@suse.cz> Message-Id: <20230227120216.31306-2-frank.li@vivo.com>
Diffstat (limited to 'fs/quota')
-rw-r--r--fs/quota/dquot.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c
index 90cb70c82012..78c9977549ef 100644
--- a/fs/quota/dquot.c
+++ b/fs/quota/dquot.c
@@ -2819,7 +2819,6 @@ EXPORT_SYMBOL(dquot_get_state);
int dquot_set_dqinfo(struct super_block *sb, int type, struct qc_info *ii)
{
struct mem_dqinfo *mi;
- int err = 0;
if ((ii->i_fieldmask & QC_WARNS_MASK) ||
(ii->i_fieldmask & QC_RT_SPC_TIMER))
@@ -2846,8 +2845,7 @@ int dquot_set_dqinfo(struct super_block *sb, int type, struct qc_info *ii)
spin_unlock(&dq_data_lock);
mark_info_dirty(sb, type);
/* Force write to disk */
- sb->dq_op->write_info(sb, type);
- return err;
+ return sb->dq_op->write_info(sb, type);
}
EXPORT_SYMBOL(dquot_set_dqinfo);