summaryrefslogtreecommitdiff
path: root/fs/xfs/xfs_message.h
diff options
context:
space:
mode:
authorDarrick J. Wong <djwong@kernel.org>2021-05-12 22:49:19 +0300
committerDarrick J. Wong <djwong@kernel.org>2021-05-25 04:01:04 +0300
commit6b69e485894b355b333bd286f0f0958e41d8754a (patch)
tree3053e6570e72b2b3593e50cb8f9cdc5d154b3ecf /fs/xfs/xfs_message.h
parent0f9342513cc78a31a4a272a19b35eee4e8cd7107 (diff)
downloadlinux-6b69e485894b355b333bd286f0f0958e41d8754a.tar.xz
xfs: standardize extent size hint validation
While chasing a bug involving invalid extent size hints being propagated into newly created realtime files, I noticed that the xfs_ioctl_setattr checks for the extent size hints weren't the same as the ones now encoded in libxfs and used for validation in repair and mkfs. Because the checks in libxfs are more stringent than the ones in the ioctl, it's possible for a live system to set inode flags that immediately result in corruption warnings. Specifically, it's possible to set an extent size hint on an rtinherit directory without checking if the hint is aligned to the realtime extent size, which makes no sense since that combination is used only to seed new realtime files. Replace the open-coded and inadequate checks with the libxfs verifier versions and update the code comments a bit. Signed-off-by: Darrick J. Wong <djwong@kernel.org> Reviewed-by: Brian Foster <bfoster@redhat.com> Reviewed-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'fs/xfs/xfs_message.h')
0 files changed, 0 insertions, 0 deletions