summaryrefslogtreecommitdiff
path: root/fs/xfs/xfs_super.c
diff options
context:
space:
mode:
authorIan Kent <raven@themaw.net>2019-11-05 00:58:44 +0300
committerDarrick J. Wong <darrick.wong@oracle.com>2019-11-05 19:28:26 +0300
commit846410ccd104c7294d18e61c665bf7c0c7e6d7d1 (patch)
tree4c4cead6cec2c7dc93d91a96a14426e36907d2bf /fs/xfs/xfs_super.c
parentc0a6791667f81d9b12443f7ed1c7b4602be9e3c9 (diff)
downloadlinux-846410ccd104c7294d18e61c665bf7c0c7e6d7d1.tar.xz
xfs: avoid redundant checks when options is empty
When options passed to xfs_parseargs() is NULL the checks performed after taking the branch are made with the initial values of dsunit, dswidth and iosizelog. But all the checks do nothing in this case so return immediately instead. Signed-off-by: Ian Kent <raven@themaw.net> Reviewed-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Diffstat (limited to 'fs/xfs/xfs_super.c')
-rw-r--r--fs/xfs/xfs_super.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
index 0dc072700599..17188a9ed541 100644
--- a/fs/xfs/xfs_super.c
+++ b/fs/xfs/xfs_super.c
@@ -199,7 +199,7 @@ xfs_parseargs(
mp->m_allocsize_log = 16; /* 64k */
if (!options)
- goto done;
+ return 0;
while ((p = strsep(&options, ",")) != NULL) {
int token;
@@ -379,7 +379,6 @@ xfs_parseargs(
return -EINVAL;
}
-done:
if (mp->m_logbufs != -1 &&
mp->m_logbufs != 0 &&
(mp->m_logbufs < XLOG_MIN_ICLOGS ||