diff options
author | Al Viro <viro@zeniv.linux.org.uk> | 2024-04-18 07:21:25 +0300 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2024-05-03 00:39:44 +0300 |
commit | b85c42981ac4abeeb15d16437c40f52a8a64787d (patch) | |
tree | da3a99d999fedb54b571e9b7c96c2c6d1f714eb5 /fs/xfs | |
parent | b1439b179d351977641a1df9745a24d08693f9d4 (diff) | |
download | linux-b85c42981ac4abeeb15d16437c40f52a8a64787d.tar.xz |
btrfs_get_bdev_and_sb(): call set_blocksize() only for exclusive opens
btrfs_get_bdev_and_sb() has two callers - btrfs_open_one_device(),
which asks for open to be exclusive and btrfs_get_dev_args_from_path(),
which doesn't. Currently it does set_blocksize() in all cases.
I'm rather dubious about the need to do set_blocksize() anywhere in btrfs,
to be honest - there's some access to page cache of underlying block
devices in there, but it's nowhere near the hot paths, AFAICT.
In any case, btrfs_get_dev_args_from_path() only needs to read
the on-disk superblock and copy several fields out of it; all
callers are only interested in devices that are already opened
and brought into per-filesystem set, so setting the block size
is redundant for those and actively harmful if we are given
a pathname of unrelated device.
So we only need btrfs_get_bdev_and_sb() to call set_blocksize()
when it's asked to open exclusive.
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Christian Brauner <brauner@kernel.org>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/xfs')
0 files changed, 0 insertions, 0 deletions