diff options
| author | Alex Elder <elder@dreamhost.com> | 2012-02-15 17:43:54 +0400 |
|---|---|---|
| committer | Alex Elder <elder@dreamhost.com> | 2012-03-22 19:47:51 +0400 |
| commit | bca064d236a2e3162a07c758855221bcbe3c475b (patch) | |
| tree | 49fca3de9007fa6cc5304bd8d7851d28cbe33110 /include/linux/ceph | |
| parent | cffaba15cd95d4a16eb5a6aa5c22a79f67d555ab (diff) | |
| download | linux-bca064d236a2e3162a07c758855221bcbe3c475b.tar.xz | |
libceph: use "do" in CRC-related Boolean variables
Change the name (and type) of a few CRC-related Boolean local
variables so they contain the word "do", to distingish their purpose
from variables used for holding an actual CRC value.
Note that in the process of doing this I identified a fairly serious
logic error in write_partial_msg_pages(): the value of "do_crc"
assigned appears to be the opposite of what it should be. No
attempt to fix this is made here; this change preserves the
erroneous behavior. The problem I found is documented here:
http://tracker.newdream.net/issues/2064
Signed-off-by: Alex Elder <elder@dreamhost.com>
Signed-off-by: Sage Weil <sage@newdream.net>
Diffstat (limited to 'include/linux/ceph')
| -rw-r--r-- | include/linux/ceph/messenger.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/linux/ceph/messenger.h b/include/linux/ceph/messenger.h index 5ca0f8244203..3bff047f6b0f 100644 --- a/include/linux/ceph/messenger.h +++ b/include/linux/ceph/messenger.h @@ -98,7 +98,7 @@ struct ceph_msg { struct ceph_msg_pos { int page, page_pos; /* which page; offset in page */ int data_pos; /* offset in data payload */ - int did_page_crc; /* true if we've calculated crc for current page */ + bool did_page_crc; /* true if we've calculated crc for current page */ }; /* ceph connection fault delay defaults, for exponential backoff */ |