summaryrefslogtreecommitdiff
path: root/net/sctp/sm_statefuns.c
diff options
context:
space:
mode:
authorJason Baron <jbaron@akamai.com>2020-02-17 23:38:09 +0300
committerDavid S. Miller <davem@davemloft.net>2020-02-18 08:33:28 +0300
commit8a9093c79863b58cc2f9874d7ae788f0d622a596 (patch)
treef86256403d55b8cd2474e808e4ba0feb404aa012 /net/sctp/sm_statefuns.c
parenta81541041ceb55bcec9a8bb8ad3482263f0a205a (diff)
downloadlinux-8a9093c79863b58cc2f9874d7ae788f0d622a596.tar.xz
net: sched: correct flower port blocking
tc flower rules that are based on src or dst port blocking are sometimes ineffective due to uninitialized stack data. __skb_flow_dissect() extracts ports from the skb for tc flower to match against. However, the port dissection is not done when when the FLOW_DIS_IS_FRAGMENT bit is set in key_control->flags. All callers of __skb_flow_dissect(), zero-out the key_control field except for fl_classify() as used by the flower classifier. Thus, the FLOW_DIS_IS_FRAGMENT may be set on entry to __skb_flow_dissect(), since key_control is allocated on the stack and may not be initialized. Since key_basic and key_control are present for all flow keys, let's make sure they are initialized. Fixes: 62230715fd24 ("flow_dissector: do not dissect l4 ports for fragments") Co-developed-by: Eric Dumazet <edumazet@google.com> Signed-off-by: Eric Dumazet <edumazet@google.com> Acked-by: Cong Wang <xiyou.wangcong@gmail.com> Signed-off-by: Jason Baron <jbaron@akamai.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sctp/sm_statefuns.c')
0 files changed, 0 insertions, 0 deletions