summaryrefslogtreecommitdiff
path: root/tools/testing/selftests/clone3/clone3_clear_sighand.c
diff options
context:
space:
mode:
authorNathan Chancellor <nathan@kernel.org>2024-04-24 20:24:04 +0300
committerShuah Khan <skhan@linuxfoundation.org>2024-05-06 22:57:20 +0300
commit5ca6110661bd601e6a791eafa92c028af1816797 (patch)
tree09aeceff8d02c8ce9b6caf68ae1b256f734a0e12 /tools/testing/selftests/clone3/clone3_clear_sighand.c
parent5b1c8b1e56ff8b5e9c1a09606af3627bb55933cf (diff)
downloadlinux-5ca6110661bd601e6a791eafa92c028af1816797.tar.xz
selftests/clone3: ksft_exit functions do not return
After commit f7d5bcd35d42 ("selftests: kselftest: Mark functions that unconditionally call exit() as __noreturn"), ksft_exit_...() functions are marked as __noreturn, which means the return type should not be 'int' but 'void' because they are not returning anything (and never were since exit() has always been called). To facilitate updating the return type of these functions, remove 'return' before the calls to ksft_exit_{pass,fail}(), as __noreturn prevents the compiler from warning that a caller of the ksft_exit functions does not return a value because the program will terminate upon calling these functions. Just removing 'return' would have resulted in !ret ? ksft_exit_pass() : ksft_exit_fail(); so convert that into the more idiomatic if (ret) ksft_exit_fail(); ksft_exit_pass(); Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com> Reviewed-by: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Nathan Chancellor <nathan@kernel.org> Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
Diffstat (limited to 'tools/testing/selftests/clone3/clone3_clear_sighand.c')
-rw-r--r--tools/testing/selftests/clone3/clone3_clear_sighand.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/testing/selftests/clone3/clone3_clear_sighand.c b/tools/testing/selftests/clone3/clone3_clear_sighand.c
index 54a8b2445be9..ce0426786828 100644
--- a/tools/testing/selftests/clone3/clone3_clear_sighand.c
+++ b/tools/testing/selftests/clone3/clone3_clear_sighand.c
@@ -120,5 +120,5 @@ int main(int argc, char **argv)
test_clone3_clear_sighand();
- return ksft_exit_pass();
+ ksft_exit_pass();
}