diff options
| author | Ovidiu Panait <ovidiu.panait@windriver.com> | 2020-09-29 20:27:13 +0300 |
|---|---|---|
| committer | Matthias Brugger <mbrugger@suse.com> | 2020-10-02 18:32:28 +0300 |
| commit | 0db912de153743e2ec97bd022640c5722eb07737 (patch) | |
| tree | f1f38e647653c7de53d0d2b6080fe9427f14ead2 /drivers/pinctrl | |
| parent | e020c07a020000d9b9cbba8ea56109b37c3926c6 (diff) | |
| download | u-boot-0db912de153743e2ec97bd022640c5722eb07737.tar.xz | |
pinctrl: bcm283x: Store the return value of dev_read_u32_default to int
Currently, the return value of dev_read_u32_default is stored in an u32,
causing the subsequent "if (function < 0)" to always be false:
u32 function;
...
function = dev_read_u32_default(config, "brcm,function", -1);
if (function < 0) {
debug("Failed reading function for pinconfig %s (%d)\n",
config->name, function);
return -EINVAL;
}
Make "function" variable an int to fix this.
Cc: Matthias Brugger <mbrugger@suse.com>
Signed-off-by: Ovidiu Panait <ovidiu.panait@windriver.com>
Signed-off-by: Matthias Brugger <mbrugger@suse.com>
Diffstat (limited to 'drivers/pinctrl')
| -rw-r--r-- | drivers/pinctrl/broadcom/pinctrl-bcm283x.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/pinctrl/broadcom/pinctrl-bcm283x.c b/drivers/pinctrl/broadcom/pinctrl-bcm283x.c index 49791c5962..41da814123 100644 --- a/drivers/pinctrl/broadcom/pinctrl-bcm283x.c +++ b/drivers/pinctrl/broadcom/pinctrl-bcm283x.c @@ -63,7 +63,7 @@ static int bcm2835_gpio_get_func_id(struct udevice *dev, unsigned int gpio) int bcm283x_pinctrl_set_state(struct udevice *dev, struct udevice *config) { u32 pin_arr[MAX_PINS_PER_BANK]; - u32 function; + int function; int i, len, pin_count = 0; if (!dev_read_prop(config, "brcm,pins", &len) || !len || |