diff options
| author | Ed Tanous <edtanous@google.com> | 2023-02-16 21:37:01 +0300 |
|---|---|---|
| committer | Ed Tanous <ed@tanous.net> | 2023-02-24 20:21:40 +0300 |
| commit | 5e7e2dc585dc7a7e62d2b648b541e7f50c39ea5d (patch) | |
| tree | ee3993e0fb2dc6e244a5fc31c7e83b26783161ee /COMMON_ERRORS.md | |
| parent | 26ccae32112679c4653c1e3f8a1203c828bea05c (diff) | |
| download | bmcweb-5e7e2dc585dc7a7e62d2b648b541e7f50c39ea5d.tar.xz | |
Take boost error_code by reference
By convention, we should be following boost here, and passing error_code
by reference, not by value. This makes our code consistent, and removes
the need for a copy in some cases.
Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Id42ea4a90b6685a84818b87d1506c11256b3b9ae
Diffstat (limited to 'COMMON_ERRORS.md')
| -rw-r--r-- | COMMON_ERRORS.md | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/COMMON_ERRORS.md b/COMMON_ERRORS.md index aa4b042654..70c09e3476 100644 --- a/COMMON_ERRORS.md +++ b/COMMON_ERRORS.md @@ -210,7 +210,7 @@ whole. BMCWEB_ROUTE("/myendpoint/<str>", [](Request& req, Response& res, const std::string& id){ crow::connections::systemBus->async_method_call( - [asyncResp](const boost::system::error_code ec, + [asyncResp](const boost::system::error_code& ec, const std::string& myProperty) { if (ec) { @@ -242,7 +242,7 @@ An implementation of the above that handles 404 would look like: BMCWEB_ROUTE("/myendpoint/<str>", [](Request& req, Response& res, const std::string& id){ crow::connections::systemBus->async_method_call( - [asyncResp](const boost::system::error_code ec, + [asyncResp](const boost::system::error_code& ec, const std::string& myProperty) { if (ec == <error code that gets returned by not found>){ messages::resourceNotFound(res); |