diff options
| author | Dan Carpenter <dan.carpenter@linaro.org> | 2023-06-15 09:09:20 +0300 |
|---|---|---|
| committer | Miquel Raynal <miquel.raynal@bootlin.com> | 2023-06-19 11:26:06 +0300 |
| commit | cefa1aaa31bd7bb73a37c15ec66a9353753b2abc (patch) | |
| tree | 54016745323aa0a362fec2e2bf798c3b780c74dd /drivers/mtd | |
| parent | a5e393c1e8760cd66b3f3860a8aede185733cd6d (diff) | |
| download | linux-cefa1aaa31bd7bb73a37c15ec66a9353753b2abc.tar.xz | |
mtd: otp: clean up on error in mtd_otp_nvmem_add()
Smatch complains that these error paths are missing cleanup:
drivers/mtd/mtdcore.c:983 mtd_otp_nvmem_add()
warn: missing unwind goto?
This needs to call nvmem_unregister(mtd->otp_user_nvmem) before
returning.
Fixes: 3b270fac8443 ("mtd: otp: Put factory OTP/NVRAM into the entropy pool")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/fe7ef901-9571-4c6e-a40e-449046efe2c6@moroto.mountain
Diffstat (limited to 'drivers/mtd')
| -rw-r--r-- | drivers/mtd/mtdcore.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c index abf4cb58a8ab..e00b12aa5ec9 100644 --- a/drivers/mtd/mtdcore.c +++ b/drivers/mtd/mtdcore.c @@ -975,12 +975,14 @@ static int mtd_otp_nvmem_add(struct mtd_info *mtd) void *otp; otp = kmalloc(size, GFP_KERNEL); - if (!otp) - return -ENOMEM; + if (!otp) { + err = -ENOMEM; + goto err; + } err = mtd_nvmem_fact_otp_reg_read(mtd, 0, otp, size); if (err < 0) { kfree(otp); - return err; + goto err; } add_device_randomness(otp, err); kfree(otp); |